[Spice-devel] [PATCH spice-gtk 1/2] session: remove channels on disconnect

Christophe Fergeau cfergeau at redhat.com
Thu Nov 13 10:29:38 PST 2014


On Thu, Nov 13, 2014 at 09:03:15AM -0500, Marc-André Lureau wrote:
> 
> I imagine delaying session_disconnect() in idle (while holding a ref)
> could work, but will bring additional issues due to its async nature.
> 
> Any other idea?

It seems delaying to idle works according to your other email. If this
causes issues, an alternative for now might be to mark the channels as
dead in spice_session_disconnect after calling spice_channel_destroy(),
and then complain loudly in spice_channel_destroy() and do not do the
unref when the object is already marked as being dead. I haven't tried
to write code for that, so I don't know how realistic this is, but it
looks like this could work, and that this would allow a transitional
period while applications are being fixed.

However, if an idle works, it's much better than this suggestion.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141113/d1755054/attachment.sig>


More information about the Spice-devel mailing list