[Spice-devel] [PATCH spice-gtk 2/2] channel: deprecate spice_channel_destroy()

[Christophe Fergeau]

On Thu, Nov 13, 2014 at 05:18:51PM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Thu, Nov 13, 2014 at 10:10 AM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> 
> > At first, I thought you meant that this function was no longer available
> > at all, causing an ABI break. After reading the full patch, it seems you
> > mean this function has no non-deprecated replacement. Indicating whether
> > this is because library users should never have called it, or because
> > it's no longer needed to call it because of XXX or YYY would be helpful
> > to people who want to get rid of deprecated calls to that method.
> >
> 
> 
> What about?
> 
> "
> This function has been deprecated because it is misleading, the object is
> not actually destroyed. And it is too easy to forget that the object is
> unref(). Instead, it is recommended to call explicitely
> spice_channel_disconnect() and g_object_unref().
> "

I'd drop the middle part "And it is too easy to forget that the object
is unref()", but yeah, this is good as this provides some guidance as to
how code using that function should be changed.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141114/4812df7f/attachment.sig>