[Spice-devel] [PATCH spice-gtk 06/13] migration: set connecting state before fd request

[Christophe Fergeau]

On Fri, Nov 14, 2014 at 12:06:30PM +0100, Marc-André Lureau wrote:
> On Fri, Nov 14, 2014 at 10:59 AM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> 
> > Hmm I only partially understood what your log meant, and tried to
> > improve it, but it's very partial. I think it's better to be explicit
> > about main context/coroutine context here, maybe something like
> >
> > "During migration, the main channel initiating the process is waiting
> > in the main context for connection completion.
> > It's migrate_channel_event_cb() which is expected to yield back to the
> > main context once all channels have completed connection"
> >
> 
> Not quite exact, migrate_channel_event_cb() is a signal handler, it
> is in the main coroutine, and it yields back to the
> coroutine which initiated the migration (the waiting main channel).

Ah right, did not double check, and inverted both sides ;)

> 
> What about?
> 
> "During migration, the main channel coroutine initiating the process is
> waiting
> for connection completion of all channels. migrate_channel_event_cb() yields
> back to the main channel coroutine once all channels have completed
> connection,
> or it will abort migration for unexpected channel events, such as
> SPICE_CHANNEL_CLOSED"

looks great, thanks, ACK.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141114/6c7d1bc0/attachment-0001.sig>