[Spice-devel] [spice-gtk][PATCH] spice-widget: Don't crash when Display is NULL

Fabiano Fidêncio fabiano at fidencio.org
Mon Nov 24 06:32:52 PST 2014


On Mon, Nov 24, 2014 at 3:27 PM, Marc-André Lureau
<marcandre.lureau at gmail.com> wrote:
> On Mon, Nov 24, 2014 at 1:25 AM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
>> Return early or warn when SpiceDisplay is NULL instead of crash, avoiding
>> segfaults when running on windows using GTK3
>
>
> Where did the crash happen?

When opening the very first window and when a any other display was being added.
I know this is probably a virt-viewer fault that we have to fix there,
I just think that if we can avoid the crash here and warn the user is
better than just crash.

Best Regards,
-- 
Fabiano Fidêncio


More information about the Spice-devel mailing list