[Spice-devel] [PATCH spice-gtk 06/15] webdav: move initialization to session

[Marc-André Lureau]

Hi

On Tue, Nov 25, 2014 at 11:49 PM, Jonathon Jongsma <jjongsma at redhat.com> wrote:
> I find this name a little inconsistent. Generally the first part of the
> function name indicates the type of object that this method belongs to.

Except constructors, like here.

> So I'd expect channel_webdav_server_new() to take a SpiceWebdavChannel*
> as its first argument, but it takes a SpiceSession* instead. So it seems
> that spice_session_webdav_server_new() would be a more appropriate name?
> Maybe even move it along to spice-session.c since its only caller just
> got moved there?

It can't easily, the constructor sets up callback in channel-webdav.


-- 
Marc-André Lureau