[Spice-devel] [PATCH spice-gtk 10/15] session: remove channels on disconnect

[Christophe Fergeau]

On Tue, Nov 25, 2014 at 02:19:23PM +0100, Marc-André Lureau wrote:
> A channel is considered to be part of a session as long as it is
> alive. However, this model is problematic, since library user may hold
> channel references, and thus the channel will remain in the
> session. Calling spice_session_disconnect() several time will end up
> calling spice_channel_destroy(), releasing references that aren't owned
> by the session. This usually causes crashes, in particular with language
> bindings that do not deal well with a library model where object can't

You should write either "objects" or "an object" here I think.

Looks good otherwise.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141126/69b99f3a/attachment-0001.sig>