[Spice-devel] [spice-gtk][PATCH v4] Added INFO messages about a file transfer

[Christophe Fergeau]

On Mon, Oct 06, 2014 at 08:35:05AM -0400, Marc-André Lureau wrote:
> 
> 
> ----- Original Message -----
> > When a file transfer starts / finishes an information message is printed (in
> > INFO log level).
> > Also INFO messages about the transfer progress are periodically printed.
> 
> Why info level and not debug?
> 
> I am not fond adding more code to the "Xfer" code limited by design, I would rather work on shared folder and dnd support.
> 
> > ---
> > changes since v4:
> >   - logging is enabled when transferring more files simultaneously
> > 
> >  gtk/channel-main.c | 42 +++++++++++++++++++++++++++++++++++++++++-
> >  1 file changed, 41 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gtk/channel-main.c b/gtk/channel-main.c
> > index 1ad090f..1e0f940 100644
> > --- a/gtk/channel-main.c
> > +++ b/gtk/channel-main.c
> > @@ -70,6 +70,8 @@ typedef struct SpiceFileXferTask {
> >      char                           buffer[FILE_XFER_CHUNK_SIZE];
> >      uint64_t                       read_bytes;
> >      uint64_t                       file_size;
> > +    GDateTime                      *start_time;
> > +    GDateTime                      *last_update;
> 
> GDateTime requires glib 2.26 (currently only 2.22 required), you need to make this code conditional.

Or we can raise the requirement in configure.ac to 2.26.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141006/dfa1cf46/attachment.sig>