[Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

[Marc-André Lureau]

On Wed, Oct 8, 2014 at 3:23 PM, Christophe Fergeau <cfergeau at redhat.com>
wrote:

> > RRCrtcChangeNotify is a event subtype of RRNotify, since that's the only
> > one we can catch here, no need to filter futher.
>
> well, let's use the more specific type then, this is the one which was
> used before so it makes things easier to follow, and RRCrtcChangeNotify
> is documented in
> http://cgit.freedesktop.org/xorg/proto/randrproto/tree/randrproto.txt
> while RRNotify is not.


So you want that?

         case RRNotify: {
+            XRRNotifyEvent *ne = (XRRNotifyEvent *) &event;
+            g_assert(ne->subtype == RRNotify_CrtcChange);

It's superflous, RRNotify_CrtcChange is a subtype of RRNotify, the only one
we can catch here.  Even if we were to receive other RRNotify events, it
wouldn't harm.



-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141008/bfc87f07/attachment.html>