[Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

Christophe Fergeau cfergeau at redhat.com
Wed Oct 8 07:07:02 PDT 2014


And I forgot again to mention that you need a #include <glib.h> or this
won't compile because of TRUE/FALSE.

Christophe

On Wed, Oct 08, 2014 at 03:59:57PM +0200, Christophe Fergeau wrote:
> On Wed, Oct 08, 2014 at 03:49:29PM +0200, Marc-André Lureau wrote:
> > On Wed, Oct 8, 2014 at 3:23 PM, Christophe Fergeau <cfergeau at redhat.com>
> > wrote:
> > 
> > > > RRCrtcChangeNotify is a event subtype of RRNotify, since that's the only
> > > > one we can catch here, no need to filter futher.
> > >
> > > well, let's use the more specific type then, this is the one which was
> > > used before so it makes things easier to follow, and RRCrtcChangeNotify
> > > is documented in
> > > http://cgit.freedesktop.org/xorg/proto/randrproto/tree/randrproto.txt
> > > while RRNotify is not.
> > 
> > 
> > So you want that?
> > 
> >          case RRNotify: {
> > +            XRRNotifyEvent *ne = (XRRNotifyEvent *) &event;
> > +            g_assert(ne->subtype == RRNotify_CrtcChange);
> 
> Oh sorry, I assumed there was a RRCrtcChangeNotify similar to
> RRScreenChangeNotify but this does not exist. I'd just add a comment
> about the kind of event we handle here /* RRCrtcChangeNotify */



> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141008/c3655027/attachment.sig>


More information about the Spice-devel mailing list