[Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

[Marc-André Lureau]

Hi

----- Original Message -----
> > I wonder if xf86-video-modesetting will reach the same crash now (since it
> > also has no crtc->driverIsPerformingTransform).
> 
> So, I guess I'm missing some context here, but in xf86CrtcScreenInit()
> if those two hooks are not implemented, it should only expose support
> for zero degree rotation (ie. rotation not supported)..  what crash
> are you seeing?

In modesetting and qxl drivers, drmmode_set_mode_major() is calling xf86CrtcRotate().
But xf86CrtcRotate() calls crtc->funcs->shadow_{destroy,allocate}() without
NULL checking in some situations and SEGV happens. See also patch with
some reference to the bug: https://freedesktop.org/patch/32869/