[Spice-devel] [PATCH xf86-qxl] Remove call to CrtcRotate()

Marc-André Lureau marcandre.lureau at gmail.com
Thu Oct 16 02:21:44 PDT 2014


Our driver doesn't support rotation, and calling CrtcRotoate()
may result in crash. Let's remove that useless call.

Fixes:
http://bugzilla.redhat.com/1067709
---
 src/qxl_drmmode.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/qxl_drmmode.c b/src/qxl_drmmode.c
index 42347e6..35d7897 100644
--- a/src/qxl_drmmode.c
+++ b/src/qxl_drmmode.c
@@ -197,9 +197,6 @@ drmmode_set_mode_major(xf86CrtcPtr crtc, DisplayModePtr mode,
 			output_count++;
 		}
 
-		if (!xf86CrtcRotate(crtc)) {
-			goto done;
-		}
 #if XORG_VERSION_CURRENT >= XORG_VERSION_NUMERIC(1,7,0,0,0)
 		crtc->funcs->gamma_set(crtc, crtc->gamma_red, crtc->gamma_green,
 				       crtc->gamma_blue, crtc->gamma_size);
@@ -354,6 +351,7 @@ drmmode_crtc_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, int num)
 	crtc = xf86CrtcCreate(pScrn, &drmmode_crtc_funcs);
 	if (crtc == NULL)
 		return;
+	crtc->driverIsPerformingTransform = FALSE;
 
 	drmmode_crtc = xnfcalloc(sizeof(drmmode_crtc_private_rec), 1);
 	drmmode_crtc->mode_crtc = drmModeGetCrtc(drmmode->fd, drmmode->mode_res->crtcs[num]);
-- 
1.9.3



More information about the Spice-devel mailing list