[Spice-devel] [PATCH xf86-video-qxl v2] Revise the XSpice audio processing to avoid the use of pthreads.

Christophe Fergeau cfergeau at redhat.com
Wed Oct 22 08:30:33 PDT 2014


On Tue, Oct 21, 2014 at 04:00:08PM -0500, Jeremy White wrote:
>  int
>  qxl_add_spice_playback_interface (qxl_screen_t *qxl)
>  {
>      int ret;
> +    struct audio_data *data = calloc(1, sizeof(*data));
>  
> -    if (qxl->playback_fifo_dir[0] == 0)
> -    {
> +    if (qxl->playback_fifo_dir[0] == 0) {
>          ErrorF("playback: no audio FIFO directory, audio is disabled\n");
> +        free(data);

Forgot to mention that there are more error situations in this function
where it looks like data would be leaked.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141022/209a8b36/attachment.sig>


More information about the Spice-devel mailing list