[Spice-devel] [PATCH spice-protocol] Add agent information message

[Pavel Grunt]

Hi,

I wanted to show information about the agent in the Guest Details dialog of virt-viewer ( http://people.freedesktop.org/~pgrunt/guest_details.png ).
The information about other components (qxl driver, spice server) may also be displayed there as well. 
I think this can be useful for a user when posting a bug, because it won't be necessary to use other tools to get these version informations.


----- Original Message -----
> 
> Hi
> 
> ----- Original Message -----
> > Message will be used by client for requesting an information about
> > a version of the agent running on the guest side.
> 
> Assuming the information is cheap to compute and send, and will be
> (almost) always queried, why not send it at beginning of session,
> when the client has a special cap set?
> 
> Regarding the protocol change, I would rather not introduce the
> sub-"type" field in a message, and instead rely on existing message
> type. This is what I'd propose:
> 
> - client: set AGENT_CAP_GUEST_VERSION
> - agent: send a  VDAgentGuestVersion when cap is set (define it as
> utf8 string)
> 
> Tbh, I worry about the usefulness of this feature. You may as well be
> interested about the version of other components in the guest. And
> to query that, you have better tools in the guest (and other
> agents/tools/daemons export that information). I am not quite sure
> what the spice client could do with this information but just expose
> it to the user, and then?...
> 
> Please clarify and provide a bug with the description of the issue.
> 
> thanks!
>