[Spice-devel] [PATCH spice 3/4] Remove spice-experimental

Marc-André Lureau marcandre.lureau at gmail.com
Fri Oct 24 08:54:06 PDT 2014


Remove unneded symbols that nobody should be using anyway.

The ABI is broken, so we may bump library version or ignore functions
removed (just like when "tunneling support" was removed)
---
 server/Makefile.am          |  1 -
 server/reds.c               | 18 ------------------
 server/smartcard.h          |  2 --
 server/spice-experimental.h | 40 ----------------------------------------
 4 files changed, 61 deletions(-)
 delete mode 100644 server/spice-experimental.h

diff --git a/server/Makefile.am b/server/Makefile.am
index e906636..89e590d 100644
--- a/server/Makefile.am
+++ b/server/Makefile.am
@@ -49,7 +49,6 @@ libspice_serverinclude_HEADERS =		\
 	spice-audio.h				\
 	spice-char.h				\
 	spice-core.h				\
-	spice-experimental.h			\
 	spice-input.h				\
 	spice-migration.h			\
 	spice-qxl.h				\
diff --git a/server/reds.c b/server/reds.c
index ef7ff62..505bacd 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -53,7 +53,6 @@
 #include "common/ring.h"
 
 #include "spice.h"
-#include "spice-experimental.h"
 #include "reds.h"
 #include "agent-msg-filter.h"
 #include "inputs_channel.h"
@@ -3120,9 +3119,6 @@ SPICE_GNUC_VISIBLE int spice_server_add_interface(SpiceServer *s,
         }
         spice_server_char_device_add_interface(s, sin);
 
-    } else if (strcmp(interface->type, SPICE_INTERFACE_NET_WIRE) == 0) {
-        spice_warning("unsupported net wire interface");
-        return -1;
     } else if (strcmp(interface->type, SPICE_INTERFACE_MIGRATION) == 0) {
         spice_info("SPICE_INTERFACE_MIGRATION");
         if (migration_interface) {
@@ -3736,20 +3732,6 @@ SPICE_GNUC_VISIBLE int spice_server_migrate_start(SpiceServer *s)
     return 0;
 }
 
-SPICE_GNUC_VISIBLE int spice_server_migrate_client_state(SpiceServer *s)
-{
-    spice_assert(reds == s);
-
-    if (!reds_main_channel_connected()) {
-        return SPICE_MIGRATE_CLIENT_NONE;
-    } else if (reds->mig_wait_connect) {
-        return SPICE_MIGRATE_CLIENT_WAITING;
-    } else {
-        return SPICE_MIGRATE_CLIENT_READY;
-    }
-    return 0;
-}
-
 SPICE_GNUC_VISIBLE int spice_server_migrate_end(SpiceServer *s, int completed)
 {
     SpiceMigrateInterface *sif;
diff --git a/server/smartcard.h b/server/smartcard.h
index 221c777..f9cbbfc 100644
--- a/server/smartcard.h
+++ b/server/smartcard.h
@@ -18,8 +18,6 @@
 #ifndef __SMART_CARD_H__
 #define __SMART_CARD_H__
 
-#include "spice-experimental.h"
-
 // Maximal length of APDU
 #define APDUBufSize 270
 
diff --git a/server/spice-experimental.h b/server/spice-experimental.h
deleted file mode 100644
index f16d555..0000000
--- a/server/spice-experimental.h
+++ /dev/null
@@ -1,40 +0,0 @@
-#ifndef __SPICE_EXPERIMENTAL_H__
-#define __SPICE_EXPERIMENTAL_H__
-
-#include "spice.h"
-
-/* tunnel interface */
-
-#define SPICE_INTERFACE_NET_WIRE "net_wire"
-#define SPICE_INTERFACE_NET_WIRE_MAJOR 1
-#define SPICE_INTERFACE_NET_WIRE_MINOR 1
-typedef struct SpiceNetWireInterface SpiceNetWireInterface;
-typedef struct SpiceNetWireInstance SpiceNetWireInstance;
-typedef struct SpiceNetWireState SpiceNetWireState;
-
-struct SpiceNetWireInterface {
-    SpiceBaseInterface base;
-
-    struct in_addr (*get_ip)(SpiceNetWireInstance *sin);
-    int (*can_send_packet)(SpiceNetWireInstance *sin);
-    void (*send_packet)(SpiceNetWireInstance *sin, const uint8_t *pkt, int len);
-};
-
-struct SpiceNetWireInstance {
-    SpiceBaseInstance base;
-    SpiceNetWireState *st;
-};
-
-void spice_server_net_wire_recv_packet(SpiceNetWireInstance *sin,
-                                       const uint8_t *pkt, int len);
-
-/* spice seamless client migration (broken) */
-enum {
-    SPICE_MIGRATE_CLIENT_NONE = 1,
-    SPICE_MIGRATE_CLIENT_WAITING,
-    SPICE_MIGRATE_CLIENT_READY,
-};
-
-int spice_server_migrate_client_state(SpiceServer *s);
-
-#endif // __SPICE_EXPERIMENTAL_H__
-- 
1.9.3



More information about the Spice-devel mailing list