[Spice-devel] [PATCH spice-gtk 1/4] build-sys: add extra dependencies on symbols files

[Christophe Fergeau]

On Wed, Oct 29, 2014 at 11:12:32AM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Wed, Oct 29, 2014 at 10:07 AM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> 
> > On Tue, Oct 28, 2014 at 09:32:22PM +0100, Marc-André Lureau wrote:
> > > Whenever the symbols files are modified, rebuild the library.
> >
> > I'm confused about that one, aren't these symbol files supposed to be
> > updated automatically with 'make update-symbol-files' when needed?
> >
> 
> No, that rule is manual only, and updates the symbol files for checking.

I know the rule is manual, however symbol files should be updated using this
rule, not manually. Doing it manually means 2 files to change, which is
easy to forget, and also makes the 'checking' part harder as the symbols
will most likely not be added in the right place in the file.

With that said, if we don't generate the symbol file automatically while
building the library, it makes sense to rebuild the library when it
changes.
/me goes to look at the patch.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141029/376685eb/attachment.sig>