[Spice-devel] [spice-gtk 03/11] Add missing (C) to copyright line

[Christophe Fergeau]

On Thu, Oct 30, 2014 at 02:27:48PM +0000, Daniel P. Berrange wrote:
> On Thu, Oct 30, 2014 at 02:55:05PM +0100, Christophe Fergeau wrote:
> > On Thu, Oct 30, 2014 at 01:38:26PM +0000, Daniel P. Berrange wrote:
> > > On Thu, Oct 30, 2014 at 02:28:25PM +0100, Marc-André Lureau wrote:
> > > > On Thu, Oct 30, 2014 at 2:22 PM, Christophe Fergeau <cfergeau at redhat.com>
> > > > wrote:
> > > > 
> > > > > On Thu, Oct 30, 2014 at 02:02:27PM +0100, Marc-André Lureau wrote:
> > > > > > Quoting GNU maintainer manual:
> > > > > > https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html
> > > > > >
> > > > > > "Alternatively, the ‘(C)’ or C-in-a-circle can be omitted entirely; the
> > > > > > word ‘Copyright’ suffices."
> > > > >
> > > > > The rule which asks for that to be done is:
> > > > > sc_copyright_format:
> > > > >         @require='Copyright .*Red 'Hat', Inc\.'                         \
> > > > >         containing='Copyright .*Red 'Hat                                \
> > > > >         halt='Red Hat copyright is missing Inc.'                        \
> > > > >           $(_sc_search_regexp)
> > > > >         @prohibit='Copyright [^(].*Red 'Hat                             \
> > > > >         halt='consistently use (C) in Red Hat copyright'                \
> > > > >           $(_sc_search_regexp)
> > > > >         @prohibit='\<Red''Hat\>'                                        \
> > > > >         halt='spell Red Hat as two words'                               \
> > > > >           $(_sc_search_regexp)
> > > > >
> > > > > I don't know if Red Hat legal department insists on the (C) being present.
> > > > > I can reword the commit log to explicit it's only being enforced for Red
> > > > > Hat's
> > > > > copyright, or I can drop the patch.
> > > > >
> > > > >
> > > > It might be specified by Red Hat legal somewhere, but then I wonder why
> > > > there wouldn't be checks for that (in RH builds checks), so it's probably
> > > > unneeded.
> > > 
> > > This syntax-check rule isn't about enforcing a legal requirement
> > > but rather ensuring that we use a consist copyright header across
> > > all source files. 
> > 
> > Do you know why it's not enforced for all copyright lines, but only for
> > Red Hat? It's up to other companies/individual to decide how they want
> > their copyright line to look with respect to (C)/Copyright/... ?
> 
> Yep, the license terms don't allow us change any Copyright line
> that other copyright holders have added.

Ah, makes sense, thanks for all the details!
I'll keep this patch then to have a consistent (C) Red Hat line in all
files and mention in the log that it only applies to RH copyright.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20141030/0463da91/attachment-0001.sig>