[Spice-devel] [PATCH v2][spice-gtk] Add GStreamer 1.0 audio support

[Victor Toso de Carvalho]

Hey,

> On Fri, Oct 31, 2014 at 10:59:20AM +0100, Victor Toso wrote:
> > From: Christophe Fergeau <cfergeau at redhat.com>
> 
> You should be the author of the patch, and mention in the commit log
> that this is based on a patch that I wrote as you made non-trivial
> changes to it.

Okay, fixed and committed! Thanks for that :)
http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=d4d60c9742390ea12db29e116f22b340efc5a67c

> As gstreamer 0.10 is no longer maintained upstream, I think we should
> drop support for it. However, this means we need to test gstreamer 1.x
> works well enough on Windows before dropping 0.10 support. So we can
> go with this solution for now while we do the windows tests, and then
> drop gstreamer 0.10 once this is working satisfactorily.
> Apart from these comments, I've tested this patch on a linux client,
> including in valgrind, and this works as expected. Patch looks fine too,
> so ACK.
> 
> Christophe

Victor Toso