[Spice-devel] [PATCH 2/2] python: Fix -Wsign-compare

Marc-André Lureau mlureau at redhat.com
Wed Sep 3 03:22:37 PDT 2014

----- Original Message -----
> On Wed, 2014-09-03 at 06:01 -0400, Marc-André Lureau wrote:
> > Can limit be negative?
> I don't think so: http://paste.stg.fedoraproject.org/4623/39072140/
> > Can limit be made unsigned instead?
> Actually, what I'm doing is making the limit unsigned, thanks for
> catching the error in the commit log :-)
> I'll rewrite the log and re-submit the patch.

No, I mean the argument passed as the limit to for_loop(self, index, limit)

ex: *__nelements, n_ptr etc

If those value can be negative, we need a check before entering the for loop with the (unsigned) cast.

More information about the Spice-devel mailing list