[Spice-devel] [PATCH 2/2 v2] python: Fix -Wsign-compare

[Marc-André Lureau]

ack

----- Original Message -----
> The return of the get_array_size() is used as a limit in a loop,
> being compared with an unsigned index (indexes are always unsigned).
> To avoid the -Wsign-compare warning, let's cast the return of the
> get_array_size() to unsigned and make GCC happier.
> ---
>  python_modules/marshal.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/python_modules/marshal.py b/python_modules/marshal.py
> index 97d02e9..1eda1ba 100644
> --- a/python_modules/marshal.py
> +++ b/python_modules/marshal.py
> @@ -162,11 +162,11 @@ def get_array_size(array, container_src):
>          rows_v = container_src.get_ref(rows)
>          # TODO: Handle multiplication overflow
>          if bpp == 8:
> -            return "(%s * %s)" % (width_v, rows_v)
> +            return "(unsigned) (%s * %s)" % (width_v, rows_v)
>          elif bpp == 1:
> -            return "(((%s + 7) / 8 ) * %s)" % (width_v, rows_v)
> +            return "(unsigned) (((%s + 7) / 8 ) * %s)" % (width_v, rows_v)
>          else:
> -            return "(((%s * %s + 7) / 8 ) * %s)" % (bpp, width_v, rows_v)
> +            return "(unsigned) (((%s * %s + 7) / 8 ) * %s)" % (bpp, width_v,
> rows_v)
>      elif array.is_bytes_length():
>          return container_src.get_ref(array.size[2])
>      else:
> --
> 1.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>