[Spice-devel] [spice-gtk] Don't report IO error on clean guest shutdown

[Fabiano Fidêncio]

On Fri, Sep 12, 2014 at 7:52 PM, Zeeshan Ali (Khattak) <zeeshanak at gnome.org>
wrote:

> On Wed, Sep 10, 2014 at 3:52 PM, Zeeshan Ali (Khattak)
> <zeeshanak at gnome.org> wrote:
> > On Wed, Sep 10, 2014 at 3:35 PM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
> >> Since commit 9cf9ca434, spice_channel_iterate() will report a
> >> SPICE_CHANNEL_ERROR_IO error to library users when
> >> SpiceChannel::has_error is set. In particular, when the server side
> >> closes its SPICE sockets because the VM is being shut down, an IO error
> >> will get reported. Prior to this change, a channel-closed event was
> >> reported on graceful VM shutdowns as there was
> >> a g_socket_condition_check() guarding the emission of the IO error
> >> signal.
> >>
> >> This commit readds the g_socket_condition_check() test, but only when
> >> SpiceChannel::has_error is set.
> >>
> >> This fixes https://bugs.freedesktop.org/show_bug.cgi?id=83692
> >> ---
> >
> > Just wanted to say that I tested this patch and it fixes the bug above.
>
> Anyone up for review? It would be nice to get this in and (if
> possible) even released before GNOME's code freeze break on Wednesday.
> Won't be bad if release before 3.14 release in two weeks either.
>


I have considered your previous comment as an ACK.
Anyway, ACK!

Best Regards,
-- 
Fabiano Fidêncio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140912/91a2614f/attachment.html>