[Spice-devel] [PATCH xf86-qxl] Fix crash when calling CrtcRotate()

[Christophe Fergeau]

On Wed, Sep 03, 2014 at 06:04:17PM +0200, Marc-André Lureau wrote:
> Although the driver doesn't support rotation, drmmode_set_mode_major may
> call CrtcRotate when the crtc mode doesn't fit on screen.
> 
> This will trigger a call to crtc->shadow_allocate() that will result in
> SEGV since our driver doesn't implement it. Instead, let's fail
> gracefully.

A bit confused that we try to call something that cannot work in our
code. Can drmmode_set_mode_major report an error rather than attempting
to rotate?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20140918/de043d38/attachment.sig>