[Spice-devel] [PATCH xf86-video-qxl] In XSpice audio, fully clear the data structure; silences valgrind warnings.

Jeremy White jwhite at codeweavers.com
Fri Sep 19 09:52:04 PDT 2014

> memset is fine with me. I'm also a bit curious about the warnings you
> got, but I guess you no longer have these around.

I recall that one of the was the inodes array.  Arguably, that was a 
bug, not just a warning silence.  (Just a bug with a very low 
probability of triggering a problem).

>> But I need to break my grumpy K&R edition 1 only ways, so it'll be a good
>> exercise for me <grin>.
>>> The memset(data.buffer, 0, data.buffer_bytes); call below becomes
>>> redundant if I''m not mistaken.
>> No, that's malloc'd.  (I suppose it should probably be a calloc, but I'd
>> feel that would be out of scope for this patch).
> Indeed it is, my bad.
> ACK patch.




More information about the Spice-devel mailing list