[Spice-devel] [PATCH] Make spice_codegen.py work on both Python 2 and 3 (take 2)

Christophe Fergeau cfergeau at redhat.com
Wed Apr 1 05:01:04 PDT 2015


Hey,

Small note on the (take 2) in the email subject, you can achieve the
same without polluting the shortlog by using the -v2 option to
git-format-patch/git-send-email.

On Tue, Mar 31, 2015 at 12:44:09PM -0500, Alexander Wauck wrote:
> This is a new version of my previous patch that does not include six.py.
> It's still kind of big, but at least it's all spice-common changes now.
> There are also a few other fixes that Christophe brought to my attention.
> Note that six now needs to be installed on the system (python-six on
> Fedora and Debian, six on PyPI).
> 
> This *should* be enough to make spice_codegen.py work on both Python 2
> and Python 3.  The major changes are as follows:

I've checked that we get the same generated code before/after this patch, and
with python 2 and python 3. I've also checked that both python-six and
python3-six are most likely installed on fedora (removing python-six is
not possible as dnf requires it, removing python3-six removes lots of
things including libreoffice), so this patch is good to go for me, ack!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150401/99d7a353/attachment.sig>


More information about the Spice-devel mailing list