[Spice-devel] [PATCH spice-gtk 3/4] main: add spice_main_update_display_enabled()

Jonathon Jongsma jjongsma at redhat.com
Fri Apr 3 09:08:27 PDT 2015


On Fri, 2015-04-03 at 11:30 -0400, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > To me this feels like internal API. I can't think of any reason that an
> > application would call _update_display_enabled() with update==FALSE. Do
> > we need to expose this function publicly?
> 
> The goal is to leave full control to an application on when to send
> monitor config, and not rely on default auto-resize timer that was
> introduced a long time ago. We already introduced spice_main_update_display()
> and spice_main_send_monitor_config() for those reasons, I think it
> makes sense to have a similar "update" function for enabling/disabling displays.
> 
> It needs to be public for applications that want to call it, and for spice-gtk
> (a different library) to use it instead of the legacy timer-based.

Fair enough. I forgot that spice-gtk was a separate library.

> 
> > Also, typo in commit message: "sendi"
> 
> ok, thanks




More information about the Spice-devel mailing list