[Spice-devel] [PATCH] server: red_channel: properly handle ACK_SYNC on BE machines

Christophe Fergeau cfergeau at redhat.com
Mon Apr 13 08:43:16 PDT 2015


On Mon, Apr 13, 2015 at 04:16:44PM +0300, Denis Kirjanov wrote:
> This fixes session setup betwen BE host and LE client
> 
> Signed-off-by: Denis Kirjanov <kda at itsirius.su>
> ---
>  server/red_channel.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/server/red_channel.c b/server/red_channel.c
> index a968309..1164cc2 100644
> --- a/server/red_channel.c
> +++ b/server/red_channel.c
> @@ -22,6 +22,7 @@
>  #include <config.h>
>  #endif
>  
> +#include <glib.h>
>  #include <stdio.h>
>  #include <stdint.h>
>  #include <netinet/in.h>
> @@ -1534,7 +1535,7 @@ int red_channel_client_handle_message(RedChannelClient *rcc, uint32_t size,
>              spice_printerr("bad message size");
>              return FALSE;
>          }
> -        rcc->ack_data.client_generation = *(uint32_t *)(message);
> +        rcc->ack_data.client_generation = GUINT32_FROM_LE(*(uint32_t *)(message));

Once again, isn't this handled by parse_msgc_ack_sync in
generated_server_demarshallers.c ? 

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150413/46c555be/attachment.sig>


More information about the Spice-devel mailing list