[Spice-devel] [PATCH spice-gtk] channel: HUP is not an error condition

[Marc-André Lureau]

----- Original Message -----
> > > Looks good to me, though I'm not sure why the G_IO_IN which you removed
> > > was there in the first place.
> > 
> > I don't know, you added this code in:
> > 
> > commit 9cd267a9db91aee10459a4a2bbb984663b03dd9e
> > Author: Christophe Fergeau <cfergeau at redhat.com>
> > Date:   Wed Sep 10 15:50:53 2014 +0200
> > 
> >     Don't report IO error on clean guest shutdown
> 
> Nope, you did add it in
> 
> commit 07a7ef001686c626ab9400876cf7117ab74abb62
> Author: Marc-André Lureau <marcandre.lureau at gmail.com>
> Date:   Fri Sep 6 20:52:45 2013 +0200
> 
>     channel: do not reenter the mainloop at every iteration

Fair enough. It looks like a left over: an adaptation of the previous condition_check(G_IO_IN) call. I don't think it helps in any way.

We can leave it or add a comment in the log. I would go with the later.