[Spice-devel] [spice-gtk][PATCH] session: Get the lock modifiers from GdkKeymap

Fabiano Fidêncio fabiano at fidencio.org
Mon Apr 27 16:28:10 PDT 2015


On Tue, Apr 14, 2015 at 8:49 AM, Marc-André Lureau <mlureau at redhat.com> wrote:
> Hi
>
> ----- Original Message -----
>> A cleaner way to get the lock modifiers, without depend on the
>> platform/backend used (as X or Wayland), is get them through GdkKeymap
>> (and its _get{caps,num,scroll}_lock_state() functions).
>> Unfortunately, get_scroll_lock_state() will only be present for Gtk+
>> 3.18.0 and when it becomes the minimal required version we can easily
>> drop the old code.
>> ---
>> Depends on https://bugzilla.gnome.org/show_bug.cgi?id=747844
>
> looks good to me, when the gdk bug is accepted, ack

As the GDK patch was pushed Today, this one was already pushed as well
(as 253224d8d49225f222082fa98582d8d61f10bf57).

Best Regards,
-- 
Fabiano Fidêncio


More information about the Spice-devel mailing list