[Spice-devel] [PATCH spice-gtk] usb: channel-new handler to be after default handlers

Fabiano Fidêncio fabiano at fidencio.org
Wed Apr 29 19:33:20 PDT 2015


On Wed, Apr 29, 2015 at 8:03 PM, Zeeshan Ali (Khattak)
<zeeshanak at gnome.org> wrote:
> On Wed, Apr 29, 2015 at 11:59 PM, Marc-André Lureau
> <marcandre.lureau at redhat.com> wrote:
>> Client usually connect to channel-new to connect their
>> handlers, such as open-fd.
>>
>> The usbmanager channel-new handler will call channel_connect() on usbredir
>> channels, which may call open-fd.
>>
>> However, open-fd can be emitted before the client had a chance to
>> connect their handlers (from the channel-new callback).
>>
>> Connecting after the default handler solves this case.
>>
>> Fixes:
>> https://bugzilla.gnome.org/show_bug.cgi?id=748665
>> ---
>
> Not in a position to judge the code but I tested this and it makes
> usb-redirection working again in Boxes.
>
> --
> Regards,
>
> Zeeshan Ali (Khattak)
> ________________________________________
> Befriend GNOME: http://www.gnome.org/friends/
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel


ACK!
-- 
Fabiano Fidêncio


More information about the Spice-devel mailing list