[Spice-devel] uxa-damage: error: implicit declaration of function

[poma]

On 03.08.2015 16:39, Christophe Fergeau wrote:
> On Mon, Aug 03, 2015 at 04:29:18PM +0200, poma wrote:
>> On 03.08.2015 10:30, Christophe Fergeau wrote:
>>> On Mon, Aug 03, 2015 at 10:15:54AM +0200, Victor Toso wrote:
>>>> Hi,
>>>>
>>>> On Fri, Jul 31, 2015 at 04:25:29PM +0200, poma wrote:
>>>>>
>>>>> Information for build xorg-x11-drv-qxl-0.1.4-4.fc24
>>>>> http://koji.fedoraproject.org/koji/buildinfo?buildID=673175
>>>>> ...
>>>>> Changelog ...
>>>>> - 1.15 ABI rebuild
>>>>>
>>>>> Is not that "1.18 ABI rebuild" - xorg-x11-server-1.18.0?
>>>>>
>>>>> https://kojipkgs.fedoraproject.org/work/tasks/7640/10517640/build.log
>>>>> ...
>>>>> uxa-damage.c:947:5: error: implicit declaration of function 'QueryGlyphExtents' [-Werror=implicit-function-declaration]
>>>>>      QueryGlyphExtents(font, charinfo, n, &extents);
>>>>>      ^
>>>>>
>>>>> Declare the function before it's used?
>>>>
>>>> This function is declared in xorg/dixfont.h (by dixfontstr.h in
>>>> uxa-damage.c) in my 1.17.2 (fedora 22).
>>>>
>>>> Looks like it was removed upstream by
>>>> http://cgit.freedesktop.org/xorg/xserver/commit/include/dixfont.h?id=b51f7f8582ab6c3cc9fa56c8d9721d0f240915e7
>>>
>>> The function is still in libxfont, it was exported both by xserver and
>>> xfont in older x.org. I came up with the attached patch last Friday
>>> which fixes the build, but there are still some potentially worrying
>>> warnings I haven't had time to look at yet.
>>>
>>> Christophe
>>>
>>
>> True
>> http://cgit.freedesktop.org/xorg/lib/libXfont/tree/include/X11/fonts/fontutil.h#n14
>> but reason why write here is to speed up fix.
> 
> fedora infrastructure already sends daily bug mail when some deps are
> broken ;)
> 
> Christophe
> 

Although "fedora infrastructure already sends daily bug mail when some deps are brokne", bugs tend not to be fixed for a long time.
Continue the sentence if you can.