[Spice-devel] [spice-gtk] channel: Don't warn when no CA is set

Christophe Fergeau cfergeau at redhat.com
Mon Aug 3 09:28:23 PDT 2015


Since v0.22~19 "Use system-wide trust certificate store", when neither
SpiceSession::ca-file nor SpiceSession::ca are set, the system-wide
CA store will be used to validate the SPICE certificates.
However, there is still a g_warn_if_fail() checking that either ca or
ca-file are set, which causes a runtime warning when trying to use the
system-wide store. This commit removes it.
---
 src/spice-channel.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/spice-channel.c b/src/spice-channel.c
index c67e0aa..e254b41 100644
--- a/src/spice-channel.c
+++ b/src/spice-channel.c
@@ -2242,7 +2242,6 @@ static int spice_channel_load_ca(SpiceChannel *channel)
     spice_session_get_ca(c->session, &ca, &size);
 
     CHANNEL_DEBUG(channel, "Load CA, file: %s, data: %p", ca_file, ca);
-    g_warn_if_fail(ca_file || ca);
 
     if (ca != NULL) {
         in = BIO_new_mem_buf(ca, size);
-- 
2.4.3



More information about the Spice-devel mailing list