[Spice-devel] [PATCH v4 37/41] proto: Improve agent dissectors

[Christophe Fergeau]

On Thu, Jul 30, 2015 at 12:10:51PM -0400, Frediano Ziglio wrote:
> > On Thu, Jul 23, 2015 at 04:54:54PM +0100, Frediano Ziglio wrote:
> > > Before was dump as raw data
> > 
> > "Before, agent-related messages could only be shown as raw data in
> > wireshark"?
> > 
> > Same question as for the QUIC changes regarding using @ifdef(WIRESHARK)
> > (or maybe they could go in a wireshark.proto file which would be parsed
> > at the same time as this one? I expect this would be more complicated?)
> > 
> > Christophe
> > 
> 
> Looks like you are asking for an "include" statement :)
> 
> I don't think that separating only there wireshark structures make much
> sense, the protocol file is now full of ws_THIS/ws_THAT and others code
> generators (beside the enumerators) ignore these wireshark only structures.

Imo, annotations and additional structures are different. It's easy
enough to ignore the annotations, while I'd probably wonder why
spice-server/spice-gtk are not using the generated marshallers for some
of the structs. This is why I think some explicit marking could improve
readability. But maybe it's just me, and both would be equally
confusing.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150804/aeaf2f0e/attachment.sig>