[Spice-devel] [spice-server PATCH v1 0/12] building with clang

Victor Toso victortoso at redhat.com
Wed Aug 5 05:23:14 PDT 2015


Hey :)

Playing a bit with clang, lots of warnings. With this series we could
build it with --enable-werror but several of this warnings are just
false positive and could be ignored.

I guess a few of this patches may be okay to go up. The clang-noise*,
if anyone finds an issue there we may address, otherwise we could add
a m4 to avoid those warnings (false-positive).


Victor Toso (7):
  glz: use PIXEL_PTR to cast PIXEL*
  migration_protocol: fix alignment warnings on _MAGIC
  jpeg_encoder: fix alignment warnings (convert_line)
  mjpeg_encoder: fix alignment warnings (pixel_converter)
  red_parse_qxl: Do not compute abs unsigned int
  red_parse_qxl: remove unused variable
  clang-noise

 server/glz_encode_tmpl.c    | 48 ++++++++++++++++++++++++---------------------
 server/jpeg_encoder.c       | 16 +++++++--------
 server/lz4_encoder.c        |  2 +-
 server/migration_protocol.h | 10 +++++-----
 server/mjpeg_encoder.c      |  9 +++++----
 server/red_parse_qxl.c      |  8 ++------
 server/red_worker.c         |  4 ++--
 server/reds.c               |  8 ++++----
 server/reds_stream.c        |  2 +-
 server/snd_worker.c         |  4 ++--
 10 files changed, 56 insertions(+), 55 deletions(-)

Victor Toso (2):
  marshaller: return void* to reserve_space function
  clang-noise
 common/canvas_base.c | 12 ++++++------
 common/marshaller.c  |  2 +-
 common/marshaller.h  |  2 +-
 common/sw_canvas.c   |  6 +++---
 4 files changed, 11 insertions(+), 11 deletions(-)

Victor Toso (3):
  macros: verify if __alloc_size__ works with clang
  macros: fix alignment issue reported by clang
  fix alignment warnings on _MAGIC

 spice/macros.h   | 5 +++--
 spice/protocol.h | 2 +-
 spice/stats.h    | 2 +-
 3 files changed, 5 insertions(+), 4 deletions(-)

-- 
2.4.3



More information about the Spice-devel mailing list