[Spice-devel] [Xspice PATCH 00/11] Xspice script, compiler warnings and README.xspice

[Uri Lublin]

On 08/05/2015 05:30 PM, Christophe Fergeau wrote:
> Hey,
>
> On Wed, Aug 05, 2015 at 02:35:00PM +0300, Uri Lublin wrote:
>> I did not push what I considered controversial:
>> 7  uxa: fix compiler warnings (initialize width, height, [xy]Dst_copy)
>> 8  configure: include assert.h and values.h (fix compiler warning y1)
>> 9  qxl_ring: replace memcpy with a simple copy_to/from_qxl_ring
>>
>>
>> 8: Marc-Andre commented we should not use AH_TOP. Also he suggested fixing
>> this in upstream uxa.
>> 7: following comment on 8 -- maybe also need to be fixed in upstream uxa.
>
> One of the warnings was avoided through
> http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=fde8a01
> (which was subsequently reworked), a second one with
> http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?id=edefb64
> The last hunk seems to still apply on the intel driver, but there are no
> warnings about this in the latest builds.
>
> The reason I was asking is because Patch 7 has been added as a patch in
> rawhide for some reason.
>

I can push 7.
I can also push 9 if there are no objections or opinions about it.

Additionally/Alternatively to 7, we can try to copy over
current upstream uxa as a drop-in, and see how it behaves.
Then fix warnings and send them upstream (or the other way
around).

Thanks,
     Uri.