[Spice-devel] [spice-common v2 2/2] Use installed spice-protocol for code generation

Frediano Ziglio fziglio at redhat.com
Mon Aug 10 10:18:05 PDT 2015


> 
> On Mon, Aug 10, 2015 at 01:08:56PM -0400, Frediano Ziglio wrote:
> > > 
> > > On Fri, Aug 07, 2015 at 06:50:18PM +0200, Christophe Fergeau wrote:
> > > > It is the installed one which is not executable.
> > > 
> > > I've sent a patch addressing that, but I still think we should keep the
> > > AM_PATH_PYTHON check as well as the $(PYTHON) spice_codegen.py calls.
> > > (ie keep this patch as is).
> > > 
> > > Christophe
> > > 
> > 
> > I tested and the "make PYTHON=python3" trick work the same with or without
> > configure check so ok.
> > 
> > I was wondering perhaps if it would be better to just call the executable
> > and perhaps remove the .py extension to make is possible to switch to
> > whatever tool/language in the future but just paranoia.
> 
> If we just call the executable rather than $(PYTHON) spice_codegen.py,
> then make PYTHON=python3 will most likely stop working.
> 
> Christophe.
> 

<paranoia>
Not if PYTHON is empty by default. Perhaps I would then use a GENERATOR_WRAPPER
instead of PYTHON. But actually is xxxx.py and it's ok as it is.
</paranoia>

Frediano


More information about the Spice-devel mailing list