[Spice-devel] [PATCH v3 06/13] Usbredir Channel: Change disconnect signature to reuse in async context

Christophe Fergeau cfergeau at redhat.com
Tue Aug 11 05:34:18 PDT 2015


On Tue, Aug 11, 2015 at 02:22:54PM +0200, Christophe Fergeau wrote:
> Hey,
> 
> Not clear at all why this is needed, even when looking at the code in
> its final state (after all patches are applied).

Ah, got it actually, it's because of
g_simple_async_result_run_in_thread(simple,
                                    spice_usbredir_channel_disconnect_device,
                                    G_PRIORITY_DEFAULT,
                                    cancellable);
in the next patch. I think I'd just introduce a wrapper function in the
next patch rather than making all direct _disconnect_device() callers
uglier.

Christohpe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150811/b562c046/attachment.sig>


More information about the Spice-devel mailing list