[Spice-devel] [spice-server PATCH v1] build-sys: remove -I spice-protocol as submodule

[Christophe Fergeau]

On Thu, Aug 13, 2015 at 12:19:57PM -0400, Frediano Ziglio wrote:
> 
> > Hey,
> > 
> > This is the same as
> > http://lists.freedesktop.org/archives/spice-devel/2015-August/021310.html
> > which is slightly more complete (checks for new enough spice-protocol,
> > and one more change in server/tests/test_spice_version.sh )
> > 
> > Christophe
> > 
> 
> I just had a look at the patch. The change to server/tests/test_spice_version.sh
> calls pkg-config directly however the autoconf/automake can be redirected using
> PKG_CONFIG environment so you could end up using two versions of pkg-config.
> 
> I don't know the better code to make sure you use a single pkg-config.
> Could be that just ${PKG_CONFIG:-pkg-config} is enough.
> Or perhaps would be better to move test_spice_version.sh to test_spice_version.ss.in
> and use autoconf to generate the test_spice_version.sh replacing the call to
> pkg-config.

This test_spice_version.sh script is actually obsolete since
ab12cf414c87e0c "build-sys: generate spice-version.h"

I'll drop the change from my commit, and send another patch to remove
that check.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150814/82670594/attachment.sig>