[Spice-devel] [PATCH v6 42/42] proto: Describe Quic image format from dissector

Frediano Ziglio fziglio at redhat.com
Fri Aug 14 06:30:14 PDT 2015


> 
> On Fri, Aug 14, 2015 at 08:37:49AM -0400, Frediano Ziglio wrote:
> > The enumerations are different as there is no such garbage collector.
> > It would make sense from the visual prospective (users that read
> > spice.proto
> > could understand fast that are only for dissector).
> > 
> > I think is up to you... what do you think?
> 
> Yes, I was asking if we wanted these annotations to make it more
> obvious to the casual reader that this is only used by the wireshark
> dissector.
> 
> Christophe
> 

To avoid too SPAM, consider this http://cgit.freedesktop.org/~fziglio/spice-protocol/log/?h=working.
I changes ifdef(DISSECTOR) to ifdef(SPICE_DISSECTOR) and added ifdef(SPICE_DISSECTOR) to structures.

Frediano


More information about the Spice-devel mailing list