[Spice-devel] [spice-gtk 1/2] build-sys: Remove spice-protocol submodule

[Christophe Fergeau]

On Fri, Aug 14, 2015 at 03:27:12PM +0200, Victor Toso wrote:
> Hi,
> 
> On Fri, Aug 07, 2015 at 12:49:22PM +0200, Christophe Fergeau wrote:
> > It's seeing regular releases and is API stable, so we don't need to
> > bundle it with spice-gtk
> > ---
> >  configure.ac | 8 +++++---
> >  spice-common | 2 +-
> >  2 files changed, 6 insertions(+), 4 deletions(-)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 1b347c0..855069f 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -73,7 +73,9 @@ AC_CHECK_LIBM
> >  AC_SUBST(LIBM)
> >
> >  AC_CONFIG_SUBDIRS([spice-common])
> > -COMMON_CFLAGS='-I ${top_srcdir}/spice-common/ -I ${top_srcdir}/spice-common/spice-protocol/'
> > +PKG_CHECK_MODULES([PROTOCOL], [spice-protocol >= 0.12.10])
> > +
> 
> I would go with SPICE_PROTOCOL just to be consistent with spice server
> as well [0] but feel free to ignore this ;)
> [0] http://lists.freedesktop.org/archives/spice-devel/2015-August/021516.html

Ah sure, initially I wanted to keep the name used in SPICE_GLIB_CFLAGS
below, to make the diff shorter, but in the end PROTOCOL_CFLAGS need to
be in COMMON_CFLAGS because of src/controller/ (unless I patch
src/controller/Makefile.am too).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150814/70cb9434/attachment.sig>