[Spice-devel] [PATCH 0/7] Implement record/replay

[Jonathon Jongsma]

On Fri, 2015-08-14 at 13:15 -0500, Jonathon Jongsma wrote:
> On Thu, 2015-08-13 at 16:25 +0100, Frediano Ziglio wrote:
> > With this series of patches is possible to record what happens to
> > spice-server and replay it.
> > The main purpose is debugging.
> > Note that these patches are quite old and none is mine (I just did
> > some minor changes).
> > These are part of a long series of patches.
> > I left in the former state to start reviewing and commenting.
> > 
> > Personally I would remove the first patch and use another type of
> > handler for the extra one. Also changes to server/spice-server.syms
> > should be updated.
> 
> I don't really have too strong of an opinion, but I also don't see any
> reason the two handlers necessarily need to have the same signature.
> Also, the name "extra_dispatcher" is rather vague. I'd prefer a nicer
> name that gave a bit more indication of what it was for.

...on the other hand, changing the signature of the original message
handlers is a bit more flexible. If the message type is provided as an
argument to the handler callbacks, you could theoretically register the
same handler callback for multiple message types. Then you could share
code between similar handlers while still being able to distinguish the
type of message.

Jonathon