[Spice-devel] [PATCH 0/7] Implement record/replay
Frediano Ziglio
fziglio at redhat.com
Mon Aug 17 01:47:33 PDT 2015
>
> On Thu, 2015-08-13 at 16:25 +0100, Frediano Ziglio wrote:
> > With this series of patches is possible to record what happens to
> > spice-server and replay it.
> > The main purpose is debugging.
> > Note that these patches are quite old and none is mine (I just did
> > some minor changes).
> > These are part of a long series of patches.
> > I left in the former state to start reviewing and commenting.
> >
> > Personally I would remove the first patch and use another type of
> > handler for the extra one. Also changes to server/spice-server.syms
> > should be updated.
>
> I don't really have too strong of an opinion, but I also don't see any
> reason the two handlers necessarily need to have the same signature.
> Also, the name "extra_dispatcher" is rather vague. I'd prefer a nicer
> name that gave a bit more indication of what it was for.
>
>
raw_handler or all_handler?
Frediano
More information about the Spice-devel
mailing list