[Spice-devel] [PATCH 5/7] server/tests/replay: introduce

[Jonathon Jongsma]

On Mon, 2015-08-17 at 14:55 -0400, Frediano Ziglio wrote:
> > 
> > On Mon, 2015-08-17 at 04:45 -0400, Frediano Ziglio wrote:
> > > > 
> > > > On Thu, 2015-08-13 at 16:25 +0100, Frediano Ziglio wrote:
> > > > > From: Alon Levy <alon at pobox.com>
> > > > > 
> > > > > usage: replay <cmdfile> <port> <client command line>
> > > > 
> > > > This usage doesn't really match the implementation below. It should be
> > > > something more like:
> > > > 
> > > > replay -p <port> -c <client command line> <cmdfile>
> > > > 
> > > > While we're on the subject, though, can we use a more specific name?
> > > > e.g. spice-replay
> > > > 
> > > 
> > > Already taken :)
> > > 
> > > http://cgit.freedesktop.org/~fziglio/spice-replay/
> > > 
> > 
> > Sorry, It seems that maybe you misunderstood my suggestion. I wasn't
> > referring to the branch name (although that's fine as well). I was
> > actually talking about the executable name for this replay utility. I
> > think it would a bit nicer if it was like
> > 
> > spice-replay -p <port> ....
> > 
> > This executable is not actually installed, so it's not a huge problem,
> > but I still feel like it should use a less-generic name.
> > 
> > 
> 
> Well, even the program is called spice-replay, see
> http://cgit.freedesktop.org/~fziglio/spice-replay/tree/Makefile.am
> 
> I think the better way to solve are use spice-client-replay and spice-server-replay so
> once installed even user is not confused.
> 
> Frediano


Ah, OK. Perhaps it was renamed later in the branch. But in these patches
that you just sent, the makefile builds a simple "replay" executable.

Jonathon