[Spice-devel] [PATCH] prevent free setting same cursor in worker in red_set_cursor

Christophe Fergeau cfergeau at redhat.com
Wed Aug 26 06:48:18 PDT 2015


On Fri, Aug 21, 2015 at 10:26:40AM +0100, Frediano Ziglio wrote:
> Currently caller don't call red_set_cursor with cursor in worker->cursor
> but in theory is possible.
> Doing so could cause the cursor to be freed and than reused as initially
> the reference counter is 1 so object is freed but then attempted to
> be used again.

I would say if the caller is doing that, then it should own a reference
to the cursor and not rely on the reference owned by 'something else'
(in this case RedWorker) to keep the object alive while it's being set.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20150826/b294785b/attachment.sig>


More information about the Spice-devel mailing list