[Spice-devel] [PATCH qxl] Xspice: Don't set defaults for the options.

[Francois Gouget]

On Mon, 10 Aug 2015, Christophe Fergeau wrote:

> On Mon, Jun 08, 2015 at 05:52:59PM +0200, Francois Gouget wrote:
> > Otherwise they override Spice server's real builtin defaults, the Xorg configuration file settings, and even the XSPICE_XXX environment variables.
> > ---
> > 
> > Without this patch, calling Xspice _without_ the '--streaming-video' 
> > option forces this setting to 'filter', overriding the 
> > XSPICE_STREAMING_VIDEO environment variable and the SpiceStreamingVideo 
> > spiceqxl.xorg.conf setting.
> 
> fwiw this belongs to the commit log, not below '---'

It mostly says the same thing as in the commit message but in a more 
concrete way. I've merged the two together.


> >  parser.add_argument('--image-compression',
> >                      choices = ['off', 'auto_glz', 'auto_lz', 'quic',
> >                                 'glz', 'lz'],
> > -                    default='auto_glz', help='auto_glz by default')
> > +                    help='auto_glz by default')
> 
> I think these help strings should be reworked now, like 'use
> spice-server defaults (auto_glz)' or something like that.

That feels like a separate issue so it should go in a separate patch.


> I assume default behaviour (ie when no args/env vars are used) is
> unchanged before/after this patch?

I rechecked and the default behavior is unchanged.

Resubmitting...

-- 
Francois Gouget <fgouget at codeweavers.com>