[Spice-devel] [PATCH v2 2/2] spiceqxl: Reject invalid boolean values, just like for other options.

[Frediano Ziglio]

> 
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> ---
>  src/qxl_option_helpers.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qxl_option_helpers.c b/src/qxl_option_helpers.c
> index a42cc84..2aba677 100644
> --- a/src/qxl_option_helpers.c
> +++ b/src/qxl_option_helpers.c
> @@ -49,6 +49,6 @@ int get_bool_option(OptionInfoPtr options, int
> option_index,
>          return TRUE;
>      }
>  
> -    fprintf(stderr, "spice: treating invalid boolean %s as true: %s\n",
> env_name, value);
> -    return TRUE;
> +    fprintf(stderr, "spice: invalid %s: %s\n", env_name, value);
> +    exit(1);
>  }
> --
> 2.5.0
> 

I think etiher we should merge first patch and discard the second or you should merge
the two patches together.

Frediano