[Spice-devel] [PATCH 15/22] tests: test_display_base: use a faster wakeup time to easily test multiple client blocking

[Jonathon Jongsma]

On Wed, 2015-12-02 at 21:55 +0100, Fabiano Fidêncio wrote:
> On Wed, Dec 2, 2015 at 5:19 PM, Frediano Ziglio <fziglio at redhat.com> wrote:
> > From: Alon Levy <alon at pobox.com>
> > 
> > ---
> >  server/tests/test_display_base.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/server/tests/test_display_base.c
> > b/server/tests/test_display_base.c
> > index c2c5705..575c704 100644
> > --- a/server/tests/test_display_base.c
> > +++ b/server/tests/test_display_base.c
> > @@ -864,7 +864,7 @@ Test *test_new(SpiceCoreInterface *core)
> > 
> >      test->core = core;
> >      test->server = server;
> > -    test->wakeup_ms = 50;
> > +    test->wakeup_ms = 1;
> >      test->cursor_notify = NOTIFY_CURSOR_BATCH;
> >      // some common initialization for all display tests
> >      printf("TESTER: listening on port %d (unsecure)\n", port);
> > --
> > 2.4.3
> > 
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/spice-devel
> 
> NAK. There is no clear reason for changing the wakeup time. Better to
> leave it out of the tree and add a doc (on spice-space.org) saying
> that it my help to easily testing multiple client blocking.
> Reviewed-by: Fabiano Fidêncio <fidencio at redhat.com>

Note that this is just a change in a test file (under server/tests/). So it's
probably not something that would be useful to document on spice-space.org.