[Spice-devel] [PATCH spice-server 1/5] worker: move surfaces to DisplayChannel

[Frediano Ziglio]

> 
> I have a favor to ask.
> 
> I found, to my delight, that this patch solves a problem with Xspice.
> That is, if I turn off dfps mode, I get drawing glitches similar to the
> 'bad' screen shot attached.  (Correct is attached for reference).
> 

So we are solving some unknown problems too! Good!

> I'm trying to build an 0.12.6 spice server and I'd like to fix this
> issue, so I can't use this patch as it is.
> 
> I spent some time trying to identify what change seems to help, and the
> attached patch seems to solve the problem.
> 
> I'm hoping that someone smarter than me can kibitz on this patch, and
> let me know if they think it's basically 'safe' or not.
> 

Yes, it's safe, is always safe to call that function.
However... this means that probably you are passing a wrong surface_id
from your software!

Frediano

> Cheers,
> 
> Jeremy
> 
> On 11/18/2015 08:33 AM, Frediano Ziglio wrote:
> >> > 
> >> > On Wed, 2015-11-18 at 08:59 -0500, Frediano Ziglio wrote:
> >>> > > I would ack but I proposed a change and implemented it so I cannot be
> >>> > > author and acker
> >>> > > 
> >>> > > Frediano
> >> > 
> >> > I would ack it too
> >> > 
> >> > Pavel
> >> > 
> 
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/spice-devel
>