[Spice-devel] [client 1/3] build-sys: Allow simultaneous support for Pulse and GStreamer audio

Christophe Fergeau cfergeau at redhat.com
Thu Dec 3 07:47:15 PST 2015


Hey,

On Wed, Dec 02, 2015 at 02:54:55PM +0100, Francois Gouget wrote:
>  ])
> -AM_CONDITIONAL([WITH_PULSE], [test "x$have_pulse" = "xyes"])
> +AM_CONDITIONAL([SUPPORT_PULSE], [test "x$enable_pulse" = "xyes"])

I"d prefer HAVE_PULSE rather than SUPPORT_PULSE to be consistent with
the naming used in spice-deps.m4 (I've changed this locally if that's ok
with you, no need to send an updated version if the change is fine with
you).

ACK apart from this.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151203/3bf7220d/attachment.sig>


More information about the Spice-devel mailing list