[Spice-devel] [PATCH spice-gtk 3/3] Use libcacard.h if possible

Christophe Fergeau cfergeau at redhat.com
Wed Dec 9 03:07:19 PST 2015


On Wed, Dec 09, 2015 at 09:31:11AM +0100, Victor Toso wrote:
> Hi,
> 
> On Mon, Nov 30, 2015 at 11:06:05PM +0100, Marc-André Lureau wrote:
> > Drop unneeded includes (that are already undirectly included).
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
> > ---
> >  src/channel-smartcard.c | 4 ----
> >  src/smartcard-manager.c | 6 +++++-
> >  src/spicy.c             | 5 -----
> >  3 files changed, 5 insertions(+), 10 deletions(-)
> > 
> > diff --git a/src/channel-smartcard.c b/src/channel-smartcard.c
> > index 942f973..7403431 100644
> > --- a/src/channel-smartcard.c
> > +++ b/src/channel-smartcard.c
> > @@ -17,10 +17,6 @@
> >  */
> >  #include "config.h"
> >  
> > -#ifdef USE_SMARTCARD
> > -#include <vreader.h>
> > -#endif
> 
> This seems to break the build with libcacard 2.5.0 ?
> Not sure why, the m4 checks looks good.

Just sent a patch which should fix things with older libcacard (I
haven't tested 2.5.0 specifically).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/spice-devel/attachments/20151209/408329c3/attachment.sig>


More information about the Spice-devel mailing list