[Spice-devel] [PATCH 6/9] worker: update comment in red_process_display

[Frediano Ziglio]

> 
> On Wed, 2015-12-09 at 12:17 +0000, Frediano Ziglio wrote:
> > From: Alon Levy <alon at pobox.com>
> > 
> > Signed-off-by: Alon Levy <alon at pobox.com>
> > ---
> >  server/red-worker.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/server/red-worker.c b/server/red-worker.c
> > index 91a116e..c6b34cf 100644
> > --- a/server/red-worker.c
> > +++ b/server/red-worker.c
> > @@ -244,8 +244,8 @@ static int red_process_display(RedWorker *worker,
> > uint32_t
> > max_pipe_size, int *r
> >                  return n;
> >              }
> >  
> > -
> > -            // TODO: change to average pipe size?
> > +            /* this is safe but slow. in the future client groups will
> > rule
> > the world, and
> > +             * dial up will live with T1 pipes in harmony */
> 
> I'm afraid I don't know what client groups are, so this comment doesn't help
> me
> much...
> 
> >              if (red_channel_max_pipe_size(RED_CHANNEL(worker
> > ->display_channel)) > max_pipe_size) {
> >                  spice_info("too many items in the display clients pipe
> > already");
> >                  return n;
> 
> Reviewed-by: Jonathon Jongsma <jjongsma at redhat.com>
> 

Would nack too

Frediano