[Spice-devel] [PATCH spice 2/9] snd: remove duplicated snd_attach_*() code

[Frediano Ziglio]

> 
> From: Marc-André Lureau <mlureau at redhat.com>
> 
> red_channel_set_data() already sets channel->data.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau at gmail.com>
> ---
>  server/sound.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/server/sound.c b/server/sound.c
> index 0c94964..5c252c1 100644
> --- a/server/sound.c
> +++ b/server/sound.c
> @@ -1520,7 +1520,6 @@ void snd_attach_playback(SpicePlaybackInstance *sin)
>      // TODO: Make RedChannel base of worker? instead of assigning it to
>      channel->data
>      channel = red_channel_create_dummy(sizeof(RedChannel),
>      SPICE_CHANNEL_PLAYBACK, 0);
>  
> -    channel->data = playback_worker;
>      client_cbs.connect = snd_set_playback_peer;
>      client_cbs.disconnect = snd_disconnect_channel_client;
>      client_cbs.migrate = snd_playback_migrate_channel_client;
> @@ -1551,7 +1550,6 @@ void snd_attach_record(SpiceRecordInstance *sin)
>      // TODO: Make RedChannel base of worker? instead of assigning it to
>      channel->data
>      channel = red_channel_create_dummy(sizeof(RedChannel),
>      SPICE_CHANNEL_RECORD, 0);
>  
> -    channel->data = record_worker;
>      client_cbs.connect = snd_set_record_peer;
>      client_cbs.disconnect = snd_disconnect_channel_client;
>      client_cbs.migrate = snd_record_migrate_channel_client;

Acked-by: Frediano Ziglio <fziglio at redhat.com>

Frediano